[ovs-dev] [PATCH] netdev-bsd: Fix use of uninitialized data in netdev_bsd_rxq_recv().
YAMAMOTO Takashi
yamamoto at valinux.co.jp
Fri Apr 17 03:30:02 UTC 2015
Acked-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> This one I should take care of it. :-)
>
> Acked-by: Kevin Lo <kevlo at FreeBSD.org>
>
> On Thu, Apr 16, 2015 at 03:08:17PM -0700, Jarno Rajahalme wrote:
>>
>> Subject should be corrected, otherwise:
>>
>> Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>
>>
>> > On Apr 16, 2015, at 2:19 PM, Ben Pfaff <blp at nicira.com> wrote:
>> >
>> > When netdev_bsd_get_mtu() failed, it didn't report the error to the caller,
>> > so the caller couldn't work around not knowing the MTU.
>> >
>> > Found by LLVM scan-build.
>> >
>> > Reported-by: Kevin Lo <kevlo at FreeBSD.org>
>> > Signed-off-by: Ben Pfaff <blp at nicira.com>
>> > ---
>> > lib/netdev-bsd.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c
>> > index 541e5ec..cc01470 100644
>> > --- a/lib/netdev-bsd.c
>> > +++ b/lib/netdev-bsd.c
>> > @@ -843,7 +843,7 @@ netdev_bsd_get_mtu(const struct netdev *netdev_, int *mtup)
>> > }
>> > ovs_mutex_unlock(&netdev->mutex);
>> >
>> > - return 0;
>> > + return error;
>> > }
>> >
>> > static int
>> > --
>> > 2.1.3
>> >
>> > _______________________________________________
>> > dev mailing list
>> > dev at openvswitch.org
>> > http://openvswitch.org/mailman/listinfo/dev
>>
>>
>>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
More information about the dev
mailing list