[ovs-dev] [PATCH ovn pipeline 6/6] ovn-northd: Implement basic Pipeline generation.

Ben Pfaff blp at nicira.com
Mon Apr 20 22:12:06 UTC 2015


On Mon, Apr 20, 2015 at 05:07:32PM -0400, Russell Bryant wrote:
> In table 1, if "eth.dst[40]" matches, the output is all ports.  Is that
> intentional?  Or should it be output to all ports except the source port?

In OpenFlow, an output to the input port is implicitly dropped.  This
is commonly helpful but occasionally annoying.  I had been tacitly
assuming that we'd put the same semantics into OVN flows, though I had
not actually written that down.

I sent out a patch to better imply that:


> > diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml
> > index 6985f5e..a1b3a07 100644
> > --- a/ovn/ovn-nb.xml
> > +++ b/ovn/ovn-nb.xml
> > @@ -144,12 +144,14 @@
> >        </p>
> >  
> >        <p>
> > -        Exact syntax is TBD.  One could simply use comma- or
> > -        space-separated L2 and L3 addresses in each set member, or
> > -        replace this by a subset of the general-purpose expression
> > -        language used for the <ref column="match" table="Pipeline"
> > -        db="OVN_Southbound"/> column in the OVN Southbound database's
> > -        <ref table="Pipeline" db="OVN_Southbound"/> table.
> > +	Each member of the set is a comma- or space-separated list.  A single
> > +	set member may have an Ethernet address, an IPv4 address, and an IPv6
> > +	address, or any subset.  Order is not significant.
> > +      </p>
> > +
> > +      <p>
> > +	TBD: exact semantics.  For now only Ethernet port security is
> > +	implemented.
> >        </p>
> >      </column>
> >  
> > 
> 
> It looks like you've got tabs here where most of the file is spaces.  I
> posted a patch to convert these XML files to exclusively use spaces for
> consistency.

Oops.  Thanks.



More information about the dev mailing list