[ovs-dev] [RFC 1/2] datapath: Fix unexported public functions in linux/compat/linux/.

Alex Wang alexw at nicira.com
Mon Apr 20 22:36:07 UTC 2015


On Mon, Apr 20, 2015 at 2:21 PM, Thomas Graf <tgraf at noironetworks.com>
wrote:

> On 04/20/15 at 12:28pm, Alex Wang wrote:
> > Thx a lot for the comments~
> >
> > I think here are my todos:
> > 1. prefix all public functions in the compat/include with rpl_ + and add
> > checks
> >     to make sure.
> > 2. export all rpl_* symbols + add check to make sure all rpl_* are
> exported.
>
> My concerns were along the same lines as Ben's reply.
> This resolution seems perfectly fine to me though.
> I don't really like exporting symbols unless needed
> but it's probably the lesser evil until we have a
> solid way of verifying runtime insertion using CI.
>

Yeah, using CI would be ideal~

Thx, I'll send out patches soon,

Alex Wang,



More information about the dev mailing list