[ovs-dev] [PATCH] datapath: Provide alternate name for setup_udp_tunnel_sock()

[Alex Wang]

On Mon, Apr 20, 2015 at 8:41 PM, Tuan Nguyen <tuan.nguyen at veriksystems.com>
wrote:

> Hi Alex Wang,
>
> I tried two patches in your link, but the bug "export duplicate symbol"
> still happened.
>
> Does I still need a patch for
> "/datapath/linux/compat/include/net/udp_tunnel.h":
>
> +#define setup_udp_tunnel_sock rpl_setup_udp_tunnel_sock
> ...
> +#define udp_tunnel_xmit_skb rpl_udp_tunnel_xmit_skb
> ...
> +#define udp_tunnel_sock_release rpl_udp_tunnel_sock_release
>
> Thanks
> Tuan Nguyen
>


The patch is just the RFC version.  I post it so that you could check the
conversation in the thread and know that I'm gonna fix it and also include
you change here.

Thanks,
Alex Wang,





>
> On Tue, Apr 21, 2015 at 5:37 AM, Alex Wang <alexw at nicira.com> wrote:
>
>> Thx Thomas, Tuan,
>>
>> Please refer to this thread for the converstaion about renaming
>> and exporting all symbols.
>>
>> http://openvswitch.org/pipermail/dev/2015-April/054259.html
>>
>> I'll credit Tuan's work,
>>
>> Thanks,
>> Alex Wang,
>>
>> On Mon, Apr 20, 2015 at 2:25 PM, Thomas Graf <tgraf at noironetworks.com>
>> wrote:
>>
>>> On 04/20/15 at 06:33pm, Tuan Nguyen wrote:
>>> > Hi Thomas Graf,
>>> >
>>> > Thanks for your help, I tried this patch and got a same bug with
>>> functions:
>>> > udp_tunnel_xmit_skb, udp_tunnel_sock_release
>>> > .
>>> > I tried to fix like your patch and all work well now.
>>>
>>> Thanks for testing! It looks like Alex is going to rename
>>> and export all of these symbols in a larger patch anyway.
>>>
>>> Alex: Please credit Tuan for his work in your patch as I'll
>>> drop mine.
>>>
>>
>>
>