[ovs-dev] [PATCH] ovn-nbctl: Add "show" command.

[Justin Pettit]

> On Apr 21, 2015, at 5:33 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> On Tue, Apr 21, 2015 at 04:54:37PM -0700, Justin Pettit wrote:
>> It's often useful to see an overview of the configuration.
>> 
>> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> 
> Looks useful, I have only one minor comment:
> 
>> +            if (lport->n_macs) {
>> +                printf("            macs: ");
>> +                for (i=0; i < lport->n_macs; i++) {
>> +                    printf("%s ", lport->macs[i]);
>> +                }
> 
> This will leave trailing white space after the last MAC address, which
> is annoying for diffs in Autotest (you end up needing the @&t@
> quadrigraph).  It's easy to avoid it if you drop the last space here:
>> +                printf("            macs: ");
> and then move the space to before %s instead of after here:
>> +                    printf("%s ", lport->macs[i]);
> 
> Acked-by: Ben Pfaff <blp at nicira.com>

Good point.  I made the change and pushed it.

--Justin