[ovs-dev] [PATCH v2] testsuite: Don't apply the testsuite.patch on non-Windows platforms.

[Gurucharan Shetty]

>
> The patch is still needed on Windows, so I suggest to keep it with
> a reference for "Windows-only" or move the requirement to
> INSTALL.Windows.md.
In INSTALL.Windows.md we get patch as a bundle in MinGW/Msys and we
ask it as a requirement to be installed. It will be a little odd to
list the 'patch' as an additional item there.


>
> Otherwise the patch looks good to me.
I took your approval and pushed it. Thanks for the review.

> Thanks
> fbl
>
>>  On Linux, you may choose to compile the kernel module that comes with
>>  the Open vSwitch distribution or to use the kernel module built into
>>  the Linux kernel (version 3.3 or later).  See the [FAQ.md] question
>> diff --git a/tests/automake.mk b/tests/automake.mk
>> index 7c699b2..e63fb19 100644
>> --- a/tests/automake.mk
>> +++ b/tests/automake.mk
>> @@ -200,10 +200,17 @@ clean-local:
>>       test ! -f '$(TESTSUITE)' || $(SHELL) '$(TESTSUITE)' -C tests
>> --clean
>>  AUTOTEST = $(AUTOM4TE) --language=autotest
>> +
>> +if WIN32
>>  $(TESTSUITE): package.m4 $(TESTSUITE_AT) $(COMMON_MACROS_AT)
>> $(TESTSUITE_PATCH) $(AM_V_GEN)$(AUTOTEST) -I '$(srcdir)' -o
>> testsuite.tmp $@.at patch -p0 testsuite.tmp $(TESTSUITE_PATCH)
>>       $(AM_V_at)mv testsuite.tmp $@
>> +else
>> +$(TESTSUITE): package.m4 $(TESTSUITE_AT) $(COMMON_MACROS_AT)
>> +     $(AM_V_GEN)$(AUTOTEST) -I '$(srcdir)' -o $@.tmp $@.at
>> +     $(AM_V_at)mv $@.tmp $@
>> +endif
>>
>>  $(KMOD_TESTSUITE): package.m4 $(KMOD_TESTSUITE_AT)
>> $(COMMON_MACROS_AT) $(AM_V_GEN)$(AUTOTEST) -I '$(srcdir)' -o $@.tmp
>> $@.at
>
>