[ovs-dev] [PATCH] datapath: Fix check-export-symbol for non-bash shells

[Alex Wang]

Thx a lot for fixing this~

Acked-by: Alex Wang <alexw at nicira.com>



On Sun, Apr 26, 2015 at 11:30 PM, YAMAMOTO Takashi <yamamoto at valinux.co.jp>
wrote:

> Avoid using a bash construct (=~) in the target.
>
> An alternative would be to make the configure script require
> bash explicitly.  (Currently it doesn't and on NetBSD /bin/ksh
> is likely used.)
>
> The code in question was introduced by
> commit b296b82a87326e68773b970284b8e012def0e3ba .
> ("datapath: Check the export of public functions in linux/compat/linux/.")
>
> Signed-off-by: YAMAMOTO Takashi <yamamoto at valinux.co.jp>
> ---
>  datapath/Makefile.am | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/datapath/Makefile.am b/datapath/Makefile.am
> index 0b0b0bd..a8e9be4 100644
> --- a/datapath/Makefile.am
> +++ b/datapath/Makefile.am
> @@ -42,19 +42,17 @@ COMPAT_EXPORTS := $(shell $(COMPAT_GET_EXPORTS))
>  check-export-symbol:
>         @for fun_ in $(COMPAT_FUNCTIONS); do \
>            if ! grep -- $${fun_}
> $(top_srcdir)/datapath/linux/compat/build-aux/export-check-whitelist >
> /dev/null; then \
> -             if [[ ! $${fun_} =~ ^rpl_* ]] \
> -                && [[ ! $${fun_} =~ ^ovs_* ]]; then \
> +             if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
>                  echo "Should prefix $${fun_} with rpl_ or ovs_."; \
>                  exit 1; \
>               fi; \
>            fi; \
>         done
>         @for fun_ in $(COMPAT_EXPORTS); do \
> -          if [[ ! $${fun_} =~ ^rpl_* ]] \
> -             && [[ ! $${fun_} =~ ^ovs_* ]]; then \
> +          if ! echo $${fun_} | grep -E '^(rpl|ovs)_'; then \
>               echo "Should prefix $${fun_} with rpl_ or ovs_."; \
>               exit 1; \
>            fi; \
>         done
>
> -all-local: check-export-symbol
> \ No newline at end of file
> +all-local: check-export-symbol
> --
> 2.2.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev
>