[ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

Pravin Shelar pshelar at nicira.com
Mon Apr 27 20:04:52 UTC 2015


On Fri, Apr 24, 2015 at 1:44 AM, Panu Matilainen <pmatilai at redhat.com> wrote:
> On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote:
>>
>> Hi all,
>>
>> Just a quick poll: are the resolutions to review comments in this patch
>> acceptable to everyone?
>>
>> If I've missed anything, or are there any additional opens that need to be
>> addressed before it can be merged, just let me know.
>>
>> Thanks in advance,
>> Mark
>>
>>>
>>> Update relevant artifacts to add support for DPDK v2.0.0
>>> - INSTALL.DPDK.md
>>> - travis build script
>>> - acinclude.m4: add 'mssse3' flag to OVS_CFLAGS
>>> - netdev-dpdk: fix build with unified offload types in DPDK v2.0.0
>>>
>>> Note that this breaks compatibility with DPDK v1.8.0
>>>
>>> v1: - update DPDK version & build instructions in INSTALL.DPDK.md
>>>     - update DPDK version and remove compile flags in travis/build.sh
>>>     - fix build with unified offload types in DPDK v2.0.0
>>>
>>> v2: - add mssse3 flag to OVS_CFLAGS in acinclude.m4
>>>     - reinstate '-Wno-cast-align' compile flag for clang
>>>     - add details of vhost user support limitations to INSTALL.DPDK.md
>>>     - refactor travis/build.sh to reflect these changes
>>>
>>> v3: -correct minor typos in commit message
>>>
>>> Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
>>> Signed-off-by: Panu Matilainen <pmatilai at redhat.com>
>
>
> It feels a bit strange to have signed off something I hadn't seen before
> this (unless it refers to the actual code change) but maybe I'm just
> unfamiliar with the signed-off protocol.
>
> That aside, yes the patch looks good to me, please go ahead with it.
>

Hi Panu,
If you are ok with your signed-off, I will go ahead with the patch.
otherwise send your asked-by and I will use that.

Thanks.



More information about the dev mailing list