[ovs-dev] [PATCH v3] datapath-windows: Removed duplicate instance pid removal

Gurucharan Shetty shettyg at nicira.com
Wed Apr 29 14:27:51 UTC 2015


On Tue, Apr 28, 2015 at 11:49 PM, Sorin Vinturis
<svinturis at cloudbasesolutions.com> wrote:
> Instance PID is already deleted in the OvsCleanupPacketQueue function.
>
> Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
> Acked-by: Nithin Raju <nithin at vmware.com>
This patch had already been applied. Did anything change?


> ---
> v2: Rebased the patch.
>
> v3: Added ack.
> ---
>  datapath-windows/ovsext/User.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/datapath-windows/ovsext/User.c b/datapath-windows/ovsext/User.c
> index 03f0377..76a9ed1 100644
> --- a/datapath-windows/ovsext/User.c
> +++ b/datapath-windows/ovsext/User.c
> @@ -163,12 +163,6 @@ OvsSubscribeDpIoctl(PVOID instanceP,
>      if (instance->packetQueue && !join) {
>          /* unsubscribe */
>          OvsCleanupPacketQueue(instance);
> -
> -        OvsAcquirePidHashLock();
> -        /* Remove the instance from pidHashArray */
> -        OvsDelPidInstance(gOvsSwitchContext, pid);
> -        OvsReleasePidHashLock();
> -
>      } else if (instance->packetQueue == NULL && join) {
>          queue = (POVS_USER_PACKET_QUEUE) OvsAllocateMemoryWithTag(
>              sizeof *queue, OVS_USER_POOL_TAG);
> --
> 1.9.0.msysgit.0
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> http://openvswitch.org/mailman/listinfo/dev



More information about the dev mailing list