[ovs-dev] [PATCH] test-ovsdb: Fix conditional statement.

Alex Wang alexw at nicira.com
Wed Apr 29 21:02:00 UTC 2015


Applied to master~

We'll discuss more over dropping the support of those old os~

Thanks,
Alex Wang,

On Wed, Apr 29, 2015 at 12:15 PM, Ben Pfaff <blp at nicira.com> wrote:

> On Wed, Apr 29, 2015 at 02:37:43PM -0400, Russell Bryant wrote:
> > On 04/29/2015 01:45 PM, Alex Wang wrote:
> > > Old version of python does not support the following conditional
> > > statement syntax in one assignment:
> > >
> > >    var = value1 if cond1 else value2
> > >
> > > This commit fixes it by convert it back to use two assignments.
> > >
> > > Signed-off-by: Alex Wang <alexw at nicira.com>
> >
> > The code looks fine, so:
> >
> > Acked-by: Russell Bryant <rbryant at redhat.com>
> >
> > ... but what system are you still supporting that doesn't have this?  It
> > looks like it was added in Python 2.5.  So, RHEL 5 or some derivative?
> > or something else?  Just curious ...
>
> We still unfortunately support a few old XenServer versions that have
> Python 2.4.
>



More information about the dev mailing list