[ovs-dev] [PATCH ovn v4 2/9] expr: Make expr_to_flows() include conj_id flows.

[Ben Pfaff]

On Wed, Apr 29, 2015 at 06:19:48PM -0700, Justin Pettit wrote:
> 
> > On Apr 29, 2015, at 10:12 AM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > When I wrote expr_to_flows() originally, I assumed that the caller could
> > simply add an appropriate conj_id=X flow for each of the conjunctive
> > matches.  I forgot that the conj_id=X flows also need to include
> > prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP
> > fields, then the conj_id=X field must match on eth_type=0x800 and
> > ip_proto=6.  That's hard for the caller to generate itself, so this commit
> > changes expr_to_matches() to generate the conj_id=X flows also.
> > 
> > Signed-off-by: Ben Pfaff <blp at nicira.com>
> 
> I assume this is unchanged from v3.

Yes, the only patch changed in v4 is (in v4) patch 3 (see inter-version
change log 0 for details).

> Acked-by: Justin Pettit <jpettit at nicira.com>

Thanks, I'll push patches 1 and 2 in a minute.