[ovs-dev] [PATCH 21/22] ofctrl: Negotiate OVN Geneve option.

Ben Pfaff blp at nicira.com
Sat Aug 1 05:15:15 UTC 2015


On Fri, Jul 31, 2015 at 10:04:35PM -0700, Alex Wang wrote:
> Is there any documentation for the ovs side geneve negotiation?

No.  What kind of documentation would help?

> > +    if (state != S_UPDATE_FLOWS
> > +        || rconn_packet_counter_n_packets(tx_counter)) {
> > +        ovn_flow_table_clear(flow_table);
> > +        return;
> >      }
> 
> Should we use maybe a boolean to mark this case, so that ofctrl_wait
> could register a wake up event for re-updating the flows?  Wonder if there
> could be a delayed flow update issue~

Only rconn_run() could cause rconn_packet_counter_n_packets() to
decrease to 0, and only ofctrl_run() calls rconn_run() on swconn, so it
shouldn't happen currently.  I guess it could happen if ofctrl_put()
were called *before* ofctrl_run() instead of after; maybe there should
be a note about that.



More information about the dev mailing list