[ovs-dev] [PATCH v2 20/21] ofctrl: Negotiate OVN Geneve option.

Ben Pfaff blp at nicira.com
Mon Aug 3 21:14:00 UTC 2015


On Mon, Aug 03, 2015 at 01:55:04PM -0700, Justin Pettit wrote:
> 
> > On Aug 3, 2015, at 1:48 PM, Ben Pfaff <blp at nicira.com> wrote:
> > 
> > On Fri, Jul 31, 2015 at 03:12:38PM -0700, Justin Pettit wrote:
> >>> On Jul 28, 2015, at 8:44 AM, Ben Pfaff <blp at nicira.com> wrote:
> >>>        if (br_int) {
> >>> +            enum mf_field_id mff_ovn_geneve = ofctrl_run(br_int);
> >>> +
> >>>            struct hmap flow_table = HMAP_INITIALIZER(&flow_table);
> >>>            rule_run(&ctx, &flow_table);
> >>> -            if (chassis_id) {
> >>>                physical_run(&ctx, br_int, chassis_id, &flow_table);
> >>> +            if (chassis_id && mff_ovn_geneve) {
> >> 
> >> Won't this prevent OVN from coming up properly if Geneve isn't a
> >> supported protocol on the host or negotiation fails?  It would be nice
> >> to still come up if STT is configured and there are any Geneve
> >> problems.
> > 
> > Good point.  I dropped this check.
> 
> I assume in the following patch that uses this field, you'll do some
> sort of check and prevent flows from being written if Geneve is
> configured and negotiation fails.

Yes, of course.

> Thanks for addressing the other issues.

You're welcome.



More information about the dev mailing list