[ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

Sorin Vinturis svinturis at cloudbasesolutions.com
Tue Aug 4 08:45:00 UTC 2015


Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) at L564 was added by my patch. Please see here: https://github.com/openvswitch/ovs/commit/d50b88bf830c401636085ecd5048e929c80fd4d2 

-Sorin

-----Original Message-----
From: Nithin Raju [mailto:nithin at vmware.com] 
Sent: Monday, 3 August, 2015 15:45
To: Sorin Vinturis
Cc: Eitan Eliahu; dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

> On Aug 2, 2015, at 9:33 PM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> Hi Nithin,
> 
> Yes, the second check, from the 564 line, is caught by the case when the OvsInitExternalNBLContext() function is called with the NBL created by OvsPartialCopyNBL().

Right, so, do we still need your patch since L564 would make sure that a duplicate external context is not added? I am ok with having an additional check, though. Your call.

thanks,
-- Nithin



More information about the dev mailing list