[ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports

[Sorin Vinturis]

Nithin,

The code snippet that you paste is from the first version of this patch, which is no longer current. There is a v2 version of this patch, [PATCH v2] datapath-windows: Solved BSOD when adding OVS ports: http://openvswitch.org/pipermail/dev/2015-July/057089.html, which adds the ndisHandle check instead of the code you are referring. The v2 patch got committed.

-Sorin

-----Original Message-----
From: Nithin Raju [mailto:nithin at vmware.com] 
Sent: Tuesday, 4 August, 2015 16:36
To: Sorin Vinturis
Cc: Eitan Eliahu; dev at openvswitch.org
Subject: Re: [ovs-dev] [PATCH] datapath-windows: Solved BSOD when adding OVS ports


> On Aug 4, 2015, at 1:45 AM, Sorin Vinturis <svinturis at cloudbasesolutions.com> wrote:
> 
> Nithin, that check (if (nbl->SourceHandle == context->ovsPool.ndisHandle) ..) at L564 was added by my patch. Please see here: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_commit_d50b88bf830c401636085ecd5048e929c80fd4d2&d=BQIFAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=K8LEl4falwGybwMNhkjlfV6n2yOWVSgOrlRCDE698NU&s=SpfcoxkTPEFep3bMt-EGs375BRou-fDDT7BwtEvrvx0&e=  

yes, I agree. It was good catch.

My question is, do you need the additional patch you are proposing in this patch. I’ve copy pasted it for convenience below:

> +    ctx = (POVS_BUFFER_CONTEXT)NET_BUFFER_LIST_CONTEXT_DATA_START(nbl);
> +    if (ctx && ctx->magic == OVS_CTX_MAGIC) {
> +        OVS_LOG_INFO("nbl context already initialized/allocated by OVS.");
> +        return ctx;
> +    }

thanks,
-- Ntihin