[ovs-dev] [PATCH] datapath: Revert "datapath: Constify netlink structs."

Joe Stringer joestringer at nicira.com
Wed Aug 5 04:36:20 UTC 2015


On 4 August 2015 at 18:07, Pravin B Shelar <pshelar at nicira.com> wrote:
> This reverts commit 2023bdcfc44c149a8e3b38dcde8f04f2ec3f8501.
> This commit is causing segfaults when genl compat code is in use.
>
> Compat code update genl_multicast_group and genl_family type objects.
> Therefore these can not be const.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

Acked-by: Joe Stringer <joestringer at nicira.com>

Hrm. I recognised that at least some of these fields were being
written to (hence why some of them are not const); None of the
compilers I used managed to pick up on these.

Is there any way to retain some of these, or are all of them written to?



More information about the dev mailing list