[ovs-dev] [PATCH] datapath: Revert "datapath: Constify netlink structs."

Pravin Shelar pshelar at nicira.com
Wed Aug 5 17:52:20 UTC 2015


On Tue, Aug 4, 2015 at 9:36 PM, Joe Stringer <joestringer at nicira.com> wrote:
> On 4 August 2015 at 18:07, Pravin B Shelar <pshelar at nicira.com> wrote:
>> This reverts commit 2023bdcfc44c149a8e3b38dcde8f04f2ec3f8501.
>> This commit is causing segfaults when genl compat code is in use.
>>
>> Compat code update genl_multicast_group and genl_family type objects.
>> Therefore these can not be const.
>>
>> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
>
> Acked-by: Joe Stringer <joestringer at nicira.com>
>
> Hrm. I recognised that at least some of these fields were being
> written to (hence why some of them are not const); None of the
> compilers I used managed to pick up on these.
>
I did not saw any compiler error either. I would see if some checks
can be added.

> Is there any way to retain some of these, or are all of them written to?

I tried to do it but both genl_multicast_group and genl_family objects
are written when we register using compat code.

I pushed the patch to master.



More information about the dev mailing list