[ovs-dev] [PATCH 3/3] tests: Add userspace-testsuite.

Joe Stringer joestringer at nicira.com
Wed Aug 5 18:22:24 UTC 2015


On 5 August 2015 at 11:08, Daniele Di Proietto <diproiettod at vmware.com> wrote:
>
>
> On 05/08/2015 18:44, "Joe Stringer" <joestringer at nicira.com> wrote:
>
>>Thanks for this Daniele.
>>
>>A couple of general things:
>>- "userspace testsuite" as a name, while accurate, is also perhaps
>>misleading as the unit tests are also userspace tests (and don't
>>require any special root privileges). I guess this class of tests
>>should be "system", in which case it would make sense to name them
>>something like "system-userspace-testsuite.at" and
>>"system-kmod-testsuite.at".
>
> I feel that those are much better names.  Should I rename also the make
> targets?

Fine by me. I don't think too many people are relying on these names
yet (CC: Andy, Thomas in case they are)


>>- We should have a new vagrant provision target in VagrantFile to run
>>these tests. This could be mentioned in the vagrant section of
>>INSTALL.md.
>
> Sure, I can do that.
>
>>- Seems like we've omitted a NEWS item for the kernel version of these
>>tests, but perhaps these should get a mention - check-ryu and
>>check-oftest have mentions there.
>
> I can add that
>
>>- All of this is linux-centric. I don't think we have to address this
>>today, as my main concern is to increase the body of these tests to
>>get more assurance on datapath behaviour. It might be a good thing to
>>keep in mind though when designing tests - Try to keep
>>platform-specific stuff inside the macros, and generic stuff inside
>>the test files.
>
> I've thought about it, but I'm not sure how easy it would be in practice
> to support other OS (especially for namespaces).
>
> I can move some more linux specific code into the macros
> (like the ip netns exec commands), but my goal for now would be to be
> able to test the userspace datapath as well as the kernel module.

Fair enough. I think that some things like this should also improve
the readability of the tests.



More information about the dev mailing list