[ovs-dev] [PATCH 1/5] classifier: Fix comment.

Joe Stringer joestringer at nicira.com
Wed Aug 5 20:35:42 UTC 2015


On 5 August 2015 at 10:53, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> ---
>  lib/classifier.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/lib/classifier.c b/lib/classifier.c
> index fc6a1f5..cba80b5 100644
> --- a/lib/classifier.c
> +++ b/lib/classifier.c
> @@ -283,11 +283,10 @@ cls_rule_is_catchall(const struct cls_rule *rule)
>      return minimask_is_catchall(rule->match.mask);
>  }
>
> -/* Makes rule invisible after 'version'.  Once that version is made invisible
> - * (by changing the version parameter used in lookups), the rule should be
> - * actually removed via ovsrcu_postpone().
> +/* Makes 'rule' invisible in 'remove_version'.  Once that version is used in
> + * lookups, the rule should be actually removed via ovsrcu_postpone().
>   *
> - * 'rule_' must be in a classifier. */
> + * 'rule' must be in a classifier. */
>  void
>  cls_rule_make_invisible_in_version(const struct cls_rule *rule,
>                                     cls_version_t remove_version)
> --
> 2.1.4
>

When this says "should be", whose job is it to remove the rule via
ovsrcu_postpone()?



More information about the dev mailing list