[ovs-dev] [ovn-controller-vtep V5 03/12] ovn-sbctl: Add ovn-sbctl.

[Russell Bryant]

----- Original Message -----
> On Fri, Aug 7, 2015 at 11:13 AM, Russell Bryant <rbryant at redhat.com> wrote:
> 
> > > +\n\
> > > +SouthBound DB commands:\n\
> > > +  show                        print overview of database contents\n\
> > > +\n\
> > > +Chassis commands:\n\
> > > +  chassis-add CHASSIS         create a new chassis named CHASSIS\n\
> >
> > encap-type and encap-ip are required here, as well.  They're shown in
> > the man page but missing from this usage output.
> >
> 
> 
> Thx for pointing this out, how about this diff:
> 
> diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
> index 970ad69..cbde60a 100644
> --- a/ovn/utilities/ovn-sbctl.c
> +++ b/ovn/utilities/ovn-sbctl.c
> @@ -290,7 +290,9 @@ SouthBound DB commands:\n\
>    show                        print overview of database contents\n\
>  \n\
>  Chassis commands:\n\
> -  chassis-add CHASSIS         create a new chassis named CHASSIS\n\
> +  chassis-add CHASSIS ENCAP-TYPE ENCAP-IP  create a new chassis named\n\
> +                                           CHASSIS with one
> encapsulation\n\
> +                                           entry of ENCAP-TYPE and
> ENCAP-IP\n\
>    chassis-del CHASSIS         delete CHASSIS and all of its encaps,\n\
>                                and gateway_ports\n\
>  \n\
> 

Looks good to me!

-- 
Russell Bryant