[ovs-dev] [PATCH 1/5] system-kmod-macros: Fix VSWITCHD_STOP.

Daniele Di Proietto diproiettod at vmware.com
Mon Aug 10 18:32:30 UTC 2015


I'm surprised as well that the tests were passing.

Sorry about this and thanks for finding out

Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

On 08/08/2015 00:28, "Joe Stringer" <joestringer at nicira.com> wrote:

>This was renamed. Surprisingly, the tests still pass without this,
>however the extra checks that this command performs were not executed.
>Fix the macro definition.
>
>Signed-off-by: Joe Stringer <joestringer at nicira.com>
>---
> tests/system-kmod-macros.at | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/system-kmod-macros.at b/tests/system-kmod-macros.at
>index eacdc5d..3f94504 100644
>--- a/tests/system-kmod-macros.at
>+++ b/tests/system-kmod-macros.at
>@@ -33,7 +33,7 @@ m4_define([OVS_TRAFFIC_VSWITCHD_START],
> # 'extra_cmds' are shell commands to be executed afte
>OVS_VSWITCHD_STOP() is
> # invoked. They can be used to perform additional cleanups such as name
>space
> # removal.
>-m4_define([OVS_KMOD_VSWITCHD_STOP],
>+m4_define([OVS_TRAFFIC_VSWITCHD_STOP],
>   [AT_CHECK([ovs-vsctl del-br br0])
>    OVS_VSWITCHD_STOP([$1])
>    AT_CHECK([:; $2])
>-- 
>2.1.4
>




More information about the dev mailing list