[ovs-dev] [PATCH 2/5] system-common-macros: Don't use bash to exec in ns.

Daniele Di Proietto diproiettod at vmware.com
Mon Aug 10 18:40:52 UTC 2015


I guess you need this to use quotes("") inside 'command'.

One effect of this change is that if 'command' contains a pipe
(or &&, or ||) just the first command will be executed inside
the namespace.  I'm not sure if it's a big problem.  What do you
think?

On 08/08/2015 00:28, "Joe Stringer" <joestringer at nicira.com> wrote:

>ip netns exec $namespace $command doesn't need to use bash to execute
>the command. Remove it.
>
>Signed-off-by: Joe Stringer <joestringer at nicira.com>
>---
> tests/system-common-macros.at | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at
>index 1321e58..fdc2bc7 100644
>--- a/tests/system-common-macros.at
>+++ b/tests/system-common-macros.at
>@@ -25,7 +25,7 @@ m4_define([ADD_NAMESPACES],
> #
> # Execute 'command' in 'namespace'
> m4_define([NS_EXEC],
>-    [ip netns exec $1 bash -c "$2"]
>+    [ip netns exec $1 $2]
> )
> 
> # NS_CHECK_EXEC([namespace], [command], other_params...)
>-- 
>2.1.4
>




More information about the dev mailing list