[ovs-dev] [PATCH] ovn-northd: Ability to detach on Windows.

[Gurucharan Shetty]

On Mon, Aug 17, 2015 at 3:12 PM, Alex Wang <alexw at nicira.com> wrote:
> Acked-by: Alex Wang <alexw at nicira.com>
>
> Thx for writing this fix,
>
> Can you also add the same line to ovn/controller/ovn-controller.c and
> ovn/controller-vtep/ovn-controller-vtep.c ?
Thanks, I did that change. I also realized that along with handling
--detach, I should also handle windows services which need a
corresponding "service_stop". So I sent a v2.

>
> Thanks,
> Alex Wang,
>
> On Mon, Aug 17, 2015 at 3:00 PM, Gurucharan Shetty <shettyg at nicira.com>
> wrote:
>>
>> A unit test for ovn-northd was hanging because ovn-northd
>> running on Windows failed to detach. The detach function
>> for Windows is implemented inside "service_start()".
>>
>> Reported-by: Alex Wang <alexw at nicira.com>
>> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
>> ---
>>  ovn/northd/ovn-northd.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
>> index d70ba39..88a0c4e 100644
>> --- a/ovn/northd/ovn-northd.c
>> +++ b/ovn/northd/ovn-northd.c
>> @@ -1121,6 +1121,7 @@ main(int argc, char *argv[])
>>
>>      fatal_ignore_sigpipe();
>>      set_program_name(argv[0]);
>> +    service_start(&argc, &argv);
>>      vlog_set_levels(NULL, VLF_CONSOLE, VLL_WARN);
>>      vlog_set_levels(&VLM_reconnect, VLF_ANY_DESTINATION, VLL_WARN);
>>      parse_options(argc, argv);
>> --
>> 1.7.9.5
>>
>