[ovs-dev] [PATCH] lib/automake.mk: Re-instate dependency generation

Mark Wutzke mark.wutzke at alliedtelesis.co.nz
Tue Aug 18 04:43:07 UTC 2015


Commit 5b3c194f (lib/automake.mk: Fix dependency typos)
introduced dependencies that do not guarantee that
lib/ofp-msgs.inc is generated before lib/ofp-msgs.c
is compiled. This results in compilation issues when
using parallel builds, or where the script is updated.

The original dependencies were correct, so re-instate
them as they were.

Signed-off-by: Mark Wutzke <mark.wutzke at alliedtelesis.co.nz>
---
 lib/automake.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/automake.mk b/lib/automake.mk
index 15a9373..354582c 100644
--- a/lib/automake.mk
+++ b/lib/automake.mk
@@ -489,14 +489,14 @@ lib/ofp-errors.inc: lib/ofp-errors.h include/openflow/openflow-common.h \
 		$(srcdir)/lib/ofp-errors.h \
 		$(srcdir)/include/openflow/openflow-common.h > $@.tmp && \
 	mv $@.tmp $@
-lib/ofp-errors.lo: lib/ofp-errors.inc
+lib/ofp-errors.c: lib/ofp-errors.inc
 CLEANFILES += lib/ofp-errors.inc
 EXTRA_DIST += build-aux/extract-ofp-errors
 
 lib/ofp-msgs.inc: lib/ofp-msgs.h $(srcdir)/build-aux/extract-ofp-msgs
 	$(AM_V_GEN)$(run_python) $(srcdir)/build-aux/extract-ofp-msgs \
 		$(srcdir)/lib/ofp-msgs.h $@ > $@.tmp && mv $@.tmp $@
-lib/ofp-msgs.lo: lib/ofp-msgs.inc
+lib/ofp-msgs.c: lib/ofp-msgs.inc
 CLEANFILES += lib/ofp-msgs.inc
 EXTRA_DIST += build-aux/extract-ofp-msgs
 
-- 
2.5.0




More information about the dev mailing list