[ovs-dev] [PATCH] tunneling: Remove gre64 tunnel support.

[Pravin Shelar]

On Mon, Jul 27, 2015 at 1:33 PM, Jesse Gross <jesse at nicira.com> wrote:
> On Tue, Jul 21, 2015 at 3:35 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
>> diff --git a/datapath-windows/ovsext/Debug.h b/datapath-windows/ovsext/Debug.h
>> index 4b7b526..e4e55ac 100644
>> --- a/datapath-windows/ovsext/Debug.h
>> +++ b/datapath-windows/ovsext/Debug.h
>> @@ -31,7 +31,6 @@
>>  #define OVS_DBG_CHECKSUM BIT32(11)
>>  #define OVS_DBG_VXLAN    BIT32(12)
>>  #define OVS_DBG_GRE      BIT32(13)
>> -#define OVS_DBG_GRE64    BIT32(14)
>>  #define OVS_DBG_ACTION   BIT32(15)
>>  #define OVS_DBG_DATAPATH BIT32(16)
>>  #define OVS_DBG_PROPERTY BIT32(17)
>
> It looks to me (although I don't know the code) that these flags
> aren't exposed externally anywhere. So I think we don't have to leave
> a hole and can shift everything else down.
>
ok.

> Grepping shows some remaining references to gre64 in the sFlow code:
> ofproto/ofproto-dpif-sflow.c:    DPIF_SFLOW_TUNNEL_GRE64,
> ofproto/ofproto-dpif-sflow.c:    DPIF_SFLOW_TUNNEL_IPSEC_GRE64,
> ofproto/ofproto-dpif-sflow.c: } else if (strcmp(type, "gre64") == 0) {
> ofproto/ofproto-dpif-sflow.c:    return DPIF_SFLOW_TUNNEL_GRE64;
> ofproto/ofproto-dpif-sflow.c: } else if (strcmp(type, "ipsec_gre64") == 0) {
> ofproto/ofproto-dpif-sflow.c:    return DPIF_SFLOW_TUNNEL_IPSEC_GRE64;
> ofproto/ofproto-dpif-sflow.c:    case DPIF_SFLOW_TUNNEL_GRE64:
> ofproto/ofproto-dpif-sflow.c:    case DPIF_SFLOW_TUNNEL_IPSEC_GRE64:
>
This was added by sFlow commit to extend support for tunnel after the
patch was posted. I will fix it.

> If you want a review from the Windows guys, you should probably
> explicitly ping one of them. Otherwise, they might not look into the
> patch at all.

ok.
I posted v2 with the changes.