[ovs-dev] [PATCH 1/2] odp-util: Fix put_nd_key().

Jarno Rajahalme jrajahalme at nicira.com
Tue Aug 18 23:17:54 UTC 2015


Actually copy the 'nd_target' from the key.

Found by inspection.

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
---
 lib/odp-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/odp-util.c b/lib/odp-util.c
index f142f03..b50d87b 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -4711,7 +4711,7 @@ get_nd_key(const struct flow *flow, struct ovs_key_nd *nd)
 static void
 put_nd_key(const struct ovs_key_nd *nd, struct flow *flow)
 {
-    memcpy(&flow->nd_target, &flow->nd_target, sizeof flow->nd_target);
+    memcpy(&flow->nd_target, nd->nd_target, sizeof flow->nd_target);
     /* nd_sll and nd_tll are stored in arp_sha and arp_tha, respectively */
     memcpy(flow->arp_sha, nd->nd_sll, ETH_ADDR_LEN);
     memcpy(flow->arp_tha, nd->nd_tll, ETH_ADDR_LEN);
-- 
2.1.4




More information about the dev mailing list