[ovs-dev] [PATCH v2] tunneling: Remove gre64 tunnel support.

Jesse Gross jesse at nicira.com
Wed Aug 19 23:17:39 UTC 2015


On Tue, Aug 18, 2015 at 12:18 PM, Pravin B Shelar <pshelar at nicira.com> wrote:
> GRE64 was introduced to extend gre key from 32-bit to 64-bit using
> gre-key and sequence number field. But GRE64 is not standard
> protocol. There are not many users of this protocol. Therefore we
> have decided to remove it.
>
> Signed-off-by: Pravin B Shelar <pshelar at nicira.com>

I would also add a note to NEWS (actually, I would mark it as
deprecated in the 2.4 NEWS as well).

> diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
> index 8a931d6..7f0b7db 100644
> --- a/ofproto/ofproto-dpif-ipfix.c
> +++ b/ofproto/ofproto-dpif-ipfix.c
> @@ -48,7 +48,7 @@ static struct ovs_mutex mutex = OVS_MUTEX_INITIALIZER;
>   * used to indicate the type of tunnel (0x01 = VxLAN, 0x02 = GRE) and the three
>   * least significant bytes hold the value of the layer 2 overlay network
>   * segment identifier: a 24-bit VxLAN tunnel's VNI or a 24-bit GRE tunnel's
> - * TNI. This is not compatible with GRE-64 or STT, as implemented in OVS, as
> + * TNI. This is not compatible with STT, as implemented in OVS, as
>   * their tunnel IDs are 64-bit.

"their" should now be "its" in the last line.

Acked-by: Jesse Gross <jesse at nicira.com>



More information about the dev mailing list