[ovs-dev] [PATCH] ovn-controller-vtep.at: Check the successful exit of ovn-controller-vtep.

Ben Pfaff blp at nicira.com
Thu Aug 20 04:55:37 UTC 2015


On Tue, Aug 18, 2015 at 05:47:18PM -0700, Alex Wang wrote:
> Signed-off-by: Alex Wang <alexw at nicira.com>
> ---
>  tests/ovn-controller-vtep.at |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
> index de97bf9..fe2fd4d 100644
> --- a/tests/ovn-controller-vtep.at
> +++ b/tests/ovn-controller-vtep.at
> @@ -85,8 +85,10 @@ m4_define([OVN_CONTROLLER_VTEP_STOP],
>    [AT_CHECK([check_logs $1])
>     AT_CHECK([ovs-appctl -t ovs-vtep exit])
>     AT_CHECK([ovs-appctl -t ovn-northd exit])
> -   AT_CHECK([ovs-appctl -t ovsdb-server exit])
>     AT_CHECK([ovs-appctl -t ovn-controller-vtep exit])
> +   # makes sure ovn-controller-vtep exits.
> +   OVS_WAIT_UNTIL([test -z "`ls | grep -- ovn-controller-vtep.pid`"])

The above test looks like a fancy form of "test ! -f
ovn-controller-vtep.pid" to me.

> +   AT_CHECK([ovs-appctl -t ovsdb-server exit])
>     AT_CHECK([ovs-appctl -t ovs-vswitchd exit])])

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list