[ovs-dev] [PATCH] ovn-controller-vtep.at: Skip test when using Windows setup.
shettyg at nicira.com
Fri Aug 21 20:15:14 UTC 2015
On Fri, Aug 21, 2015 at 12:59 PM, Ben Pfaff <blp at nicira.com> wrote:
> On Mon, Aug 17, 2015 at 03:09:46PM -0700, Alex Wang wrote:
>> The 'ovs-vtep' simulator is not ported to Windows. So, for now,
>> just skip all tests in ovn-controller-vtep.at when running in
>> Signed-off-by: Alex Wang <alexw at nicira.com>
>> - [OVS_RUNDIR=`pwd`; export OVS_RUNDIR
>> + [
>> + # this will cause skip when 'make check' using Windows setup.
>> + AT_SKIP_IF([test $HAVE_PYTHON = no])
> Is it a Python or a Windows incompatibility? If it's really the latter,
> then I'd recommend using "$IS_WIN32" = yes" instead.
My thinking was along the lines that all tests that use python code
need to have HAVE_PYTHON test. That has been the strategy for all
other python tests being skipped in Windows to prevent many individual
tests from having IS_WIN32 check in addition to HAVE_PYTHON test. I am
fine either way.
> Acked-by: Ben Pfaff <blp at nicira.com>
> dev mailing list
> dev at openvswitch.org
More information about the dev