[ovs-dev] [PATCH] ovs-vsctl.at: Fix a ssl unit test on Windows.

Ben Pfaff blp at nicira.com
Mon Aug 24 17:16:36 UTC 2015


On Mon, Aug 24, 2015 at 07:45:22AM -0700, Gurucharan Shetty wrote:
> In Windows, when we do a 'pwd', it calls 'pwd -W' to give
> a Windows path. ovs-pki utility does not understand Windows
> path style, so the test fails. This commit prevents the
> overloading of 'pwd' command to let ovs-pki generate the
> certificates correctly.
> 
> Reported-by: Ben Pfaff <blp at nicira.com>
> Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>

I don't see very complicated use of the pkidir in ovs-pki.  Do you have
an idea of what the problem is?  It might be nice to fix ovs-pki, if
possible, to accept the other format.

Would you mind adding a comment here explaining what's going on?

> -PKIDIR=`pwd`
> +PKIDIR=`command pwd`
>  OVS_PKI="sh $abs_top_srcdir/utilities/ovs-pki.in --dir=$PKIDIR/pki --log=$PKIDIR/ovs-pki.log"
>  $OVS_PKI -B 1024 init && \

Acked-by: Ben Pfaff <blp at nicira.com>



More information about the dev mailing list