[ovs-dev] [PATCH] lib/automake.mk: Re-instate dependency generation
Mark.Wutzke at alliedtelesis.co.nz
Tue Aug 25 02:46:54 UTC 2015
Thanks for that. Yes you are correct - my mistake.
It was a combination on a number of commits (this one and others related
to changing the location of the generated .inc files), and the lack of a
clean build that caused this perception.
On 21/08/15 13:17, Ben Pfaff wrote:
> On Tue, Aug 18, 2015 at 04:43:07PM +1200, Mark Wutzke wrote:
>> Commit 5b3c194f (lib/automake.mk: Fix dependency typos)
>> introduced dependencies that do not guarantee that
>> lib/ofp-msgs.inc is generated before lib/ofp-msgs.c
>> is compiled. This results in compilation issues when
>> using parallel builds, or where the script is updated.
>> The original dependencies were correct, so re-instate
>> them as they were.
>> Signed-off-by: Mark Wutzke <mark.wutzke at alliedtelesis.co.nz>
> I don't understand. Even when I apply the following, I can't provoke
> such a failure:
> diff --git a/lib/automake.mk b/lib/automake.mk
> index 15a9373..7cde717 100644
> --- a/lib/automake.mk
> +++ b/lib/automake.mk
> @@ -494,7 +494,7 @@ CLEANFILES += lib/ofp-errors.inc
> EXTRA_DIST += build-aux/extract-ofp-errors
> lib/ofp-msgs.inc: lib/ofp-msgs.h $(srcdir)/build-aux/extract-ofp-msgs
> - $(AM_V_GEN)$(run_python) $(srcdir)/build-aux/extract-ofp-msgs \
> + sleep 1; $(AM_V_GEN)$(run_python) $(srcdir)/build-aux/extract-ofp-msgs \
> $(srcdir)/lib/ofp-msgs.h $@ > $@.tmp && mv $@.tmp $@
> lib/ofp-msgs.lo: lib/ofp-msgs.inc
> CLEANFILES += lib/ofp-msgs.inc
More information about the dev