[ovs-dev] [PATCH 2/7] ovs-ofctl: Document missing shorthand notations.

Russell Bryant rbryant at redhat.com
Tue Aug 25 19:37:14 UTC 2015


On 08/24/2015 09:12 PM, Justin Pettit wrote:
> Some new shorthands were added to ovs-ofctl, but not documented in the
> man page.  This adds most of them.  A couple were left out that would
> print differently than they would be input.  For example, we accept
> "ip6" and "ipv6", but we would output it as "ipv6", so "ip6" is not
> documented.
> 
> Signed-off-by: Justin Pettit <jpettit at nicira.com>
> ---
>  utilities/ovs-ofctl.8.in |   21 +++++++++++++++++++++
>  1 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
> index 4181d82..7060aaf 100644
> --- a/utilities/ovs-ofctl.8.in
> +++ b/utilities/ovs-ofctl.8.in
> @@ -969,24 +969,45 @@ The following shorthand notations are also available:
>  .IP \fBip\fR
>  Same as \fBdl_type=0x0800\fR.
>  .
> +.IP \fBipv6\fR
> +Same as \fBdl_type=0x86dd\fR.
> +.
>  .IP \fBicmp\fR
>  Same as \fBdl_type=0x0800,nw_proto=1\fR.
>  .
> +.IP \fBicmp6\fR
> +Same as \fBdl_type=0x86dd,nw_proto=1\fR.
> +.

Should this be nw_proto=58?

Otherwise, all of these changes line up with what I see in ofp-parse.c,
so ACK with the above fix.

Acked-by: Russell Bryant <rbryant at redhat.com>

-- 
Russell Bryant



More information about the dev mailing list