[ovs-dev] [PATCH/RFC] ovs-ctl: do not attempt to restore flows when called with --delete-bridges

Simon Horman simon.horman at netronome.com
Wed Aug 26 01:05:53 UTC 2015


On Tue, Aug 25, 2015 at 01:42:04PM -0700, Gurucharan Shetty wrote:
> On Mon, Aug 24, 2015 at 5:29 PM, Simon Horman
> <simon.horman at netronome.com> wrote:
> > On Fri, Aug 21, 2015 at 10:25:22AM -0700, Gurucharan Shetty wrote:
> >> On Thu, Aug 20, 2015 at 4:45 PM, Simon Horman
> >> <simon.horman at netronome.com> wrote:
> >> > When called with --delete-bridges saved flows cannot be restored as the
> >> > bridges to which they belong no longer exist. This results in the following
> >> > error messages on restart.
> >> >
> >> > ovs-ofctl: br0 is not a bridge or a socket
> >> > Restoring saved flows ... failed!
> >> >
> >> > Although there is no effect of this error other than the message
> >> > it seems worth avoiding. This patch does so by skipping saving of flows
> >> > when --delete-bridges is in effect.
> >> >
> >> > As flows are no longer saved when --delete-bridges is in effect
> >> > a side-effect of this change is that restart may be faster when
> >> > there are many flows.
> >> >
> >> > Signed-off-by: Simon Horman <simon.horman at netronome.com>
> >> Acked-by: Gurucharan Shetty <gshetty at nicira.com>
> >>  (I will apply this in a few hours, if no one else has any comments)
> >
> > Thanks.
> >
> > I am wondering if this could be considered branch-2.x and in particular
> > branch-2.4. It appears that the patch applies cleanly to all branch-2.x
> > branches.
> 
> Okay. I cherry-picked it to 2.4 and 2.3. If you need further
> backports, let me know.

Great, thanks.



More information about the dev mailing list