[ovs-dev] [PATCH] create dir if not exist

Rongqing Li rongqing.li at windriver.com
Wed Aug 26 04:59:21 UTC 2015



On 2015年08月26日 12:34, Ben Pfaff wrote:
> On Wed, Aug 26, 2015 at 12:28:49PM +0800, Rongqing Li wrote:
>> On 2015年08月26日 11:48, Ben Pfaff wrote:
>>> On Wed, Aug 26, 2015 at 11:10:56AM +0800, rongqing.li at windriver.com wrote:
>>>> From: Roy Li <rongqing.li at windriver.com>
>>>>
>>>> If build dir is not same as the source code, make the target .in wrong
>>>> due to no dir:
>>>> 	vswitchd/ovs-vswitchd.conf.db.5.tmp: No such file or directory
>>>>
>>>> The target .in has not dependency, but in fact, it needs other target to
>>>> create the dir to put its result, like builddir/vswitchd in below:
>>>>
>>>> /usr/bin/perl soexpand.pl < ${S}/vswitchd/ovs-vswitchd.8.in | \
>>>>      sed \
>>>>          -e 's,[@]PKIDIR[@],/var/lib/openvswitch/pki,g' \
>>>>             ......
>>>>              > vswitchd/ovs-vswitchd.8.tmp
>>>>
>>>> fix it by creating the dir in .in target
>>>>
>>>> Signed-off-by: Roy Li <rongqing.li at windriver.com>
>>>
>>> Running "configure" creates all the necessary directories, so this patch
>>> is not necessary.
>>>
>>>
>>
>>
>> after configure, I did not find the vswitchd dir under building dir.
>>
>>
>>
>> the vswitchd dir is created in Makefile.am:
>>
>>
>> vswitchd/$(am__dirstamp):
>>          @$(MKDIR_P) vswitchd
>>          @: > vswitchd/$(am__dirstamp)
>
> No such text appears in Makefile.am.  Where did you get your copy of
> OVS?
>

sorry, this is older version

>> similar issues for other dirs
>
> I guess there's something busted with your Autoconf or Automake.
>

you are right, we use disable-dependency-tracking for autoconf

thanks

-Roy

> blp at sigabrt:~/nicira/ovs(0)$ rm -rf _test
> blp at sigabrt:~/nicira/ovs(0)$ mkdir _test
> blp at sigabrt:~/nicira/ovs(0)$ cd _test
> blp at sigabrt:~/nicira/ovs/_test(1)$ ../configure -q
> blp at sigabrt:~/nicira/ovs/_test(1)$ find . -type d -print
> .
> ./ovsdb
> ./ovsdb/.deps
> ./tests
> ./tests/dpdk
> ./tests/dpdk/.deps
> ./tests/.deps
> ./vtep
> ./vtep/.deps
> ./vswitchd
> ./vswitchd/.deps
> ./lib
> ./lib/.deps
> ./lib/lldp
> ./lib/lldp/.deps
> ./include
> ./include/openflow
> ./include/openvswitch
> ./ovn
> ./ovn/controller
> ./ovn/controller/.deps
> ./ovn/controller-vtep
> ./ovn/controller-vtep/.deps
> ./ovn/lib
> ./ovn/lib/.deps
> ./ovn/northd
> ./ovn/northd/.deps
> ./ovn/utilities
> ./ovn/utilities/.deps
> ./datapath
> ./datapath/linux
> ./utilities
> ./utilities/.deps
> ./utilities/bugtool
> ./ofproto
> ./ofproto/.deps
>
>

-- 
Best Reagrds,
Roy | RongQing Li



More information about the dev mailing list