[ovs-dev] [PATCH v6 2/3] ovn: Automatically create br-int in ovn-controller.

Ben Pfaff blp at nicira.com
Wed Aug 26 14:58:12 UTC 2015


On Tue, Aug 25, 2015 at 02:11:44PM -0400, Russell Bryant wrote:
> ovn-controller previously required the integration bridge to be
> created before running ovn-controller.  This patch makes
> ovn-controller automatically create it if it doesn't already exist.
> 
> Signed-off-by: Russell Bryant <rbryant at redhat.com>

Clang has some complaints:

../ovn/controller/ovn-controller.c:306:9: error: variable 'mappings_cfg' is used
      uninitialized whenever 'if' condition is false
      [-Werror,-Wsometimes-uninitialized]
    if (cfg) {
        ^~~
../ovn/controller/ovn-controller.c:309:10: note: uninitialized use occurs here
    if (!mappings_cfg) {
         ^~~~~~~~~~~~
../ovn/controller/ovn-controller.c:306:5: note: remove the 'if' if its condition
      is always true
    if (cfg) {
    ^~~~~~~~~
../ovn/controller/ovn-controller.c:302:29: note: initialize the variable
      'mappings_cfg' to silence this warning
    const char *mappings_cfg;
                            ^
                             = NULL



More information about the dev mailing list