[ovs-dev] [PATCH 1/2] meta-flow: Initialize the whole exact_match_mask.

Jarno Rajahalme jrajahalme at nicira.com
Thu Aug 27 17:52:55 UTC 2015


> On Aug 26, 2015, at 6:56 PM, Jesse Gross <jesse at nicira.com> wrote:
> 
> On Wed, Aug 26, 2015 at 5:42 PM, Jarno Rajahalme <jrajahalme at nicira.com> wrote:
>> Initialize the whole 'exact_match_mask' in
>> mf_mask_field_and_prereqs(), as geneve options can be bigger than 16
>> bytes.
>> 
>> Requested-by: Jesse Gross <jesse at nicira.com>
>> Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
> 
> Acked-by: Jesse Gross <jesse at nicira.com>
> 
> I think we can actually do the same memset optimization in
> mf_mask_field() as well.

I moved the exact_match_mask to global scope and used it in both. I exposed the global variable in meta-flow.h and moved the initializers to meta-flow.c, and pushed to master with these changes.

Thanks for the review and the improvement suggestion!

  Jarno




More information about the dev mailing list