[ovs-dev] [PATCH 1/3] rhel: Use same rundir for ovs and ovn.

Flavio Leitner fbl at redhat.com
Thu Aug 27 21:49:12 UTC 2015


On Thu, Aug 27, 2015 at 05:16:19PM -0400, Russell Bryant wrote:
> On 08/27/2015 04:26 PM, Flavio Leitner wrote:
> > On Thu, Aug 27, 2015 at 03:49:13PM -0400, Russell Bryant wrote:
> >> On 08/27/2015 03:26 PM, Flavio Leitner wrote:
> >>> On Wed, Aug 26, 2015 at 05:46:53PM -0400, Russell Bryant wrote:
> >>>> The previous systemd units for OVN had systemd create a rundir for
> >>>> each daemon (ovn-northd and ovn-controller).  This "worked", in that
> >>>> the services did start successfully.  However, they didn't actually
> >>>> work.  In practice, both services make use of files in the main ovs
> >>>> rundir, so just run everything from there.  It keeps things simple and
> >>>> makes the services actually work.
> >>>
> >>> The above sounds like a bug somewhere else.
> >>> Why are they not using the correct OVS_RUNDIR?
> >>>
> >>> The good thing about having different directories for each service
> >>> is that we can have more specific selinux rules and permissions.
> >>
> >> OK, I wasn't sure about the benefits of keeping them separate.
> >>
> >> I *think* ovn-controller is the only one where I hit a problem I
> >> couldn't work around without a patch.  Making them all use the same
> >> rundir (this patch) was one option.  There are others, though.
> >>
> >> In ovn/controller/ofctrl.c, ofctrl_run(), we have:
> >>
> >>>   target = xasprintf("unix:%s/%s.mgmt", ovs_rundir(), br_int->name);
> >>
> >> ovs_rundir() gives the dir for ovn-controller, where we actually need
> >> the rundir for ovs-vswitchd here.
> > 
> > I see, so they actually share the same directory, in that case your 
> > patch looks ok.
> 
> OK, thanks!  Should I take that as an ACK?

Oops,
Acked-by: Flavio Leitner <fbl at sysclose.org>




More information about the dev mailing list