[ovs-dev] [PATCH v4] datapath-windows: Output a packet to two or more VXLAN ports

Nithin Raju nithin at vmware.com
Thu Aug 27 22:27:57 UTC 2015


> On Aug 27, 2015, at 3:08 PM, Alin Serdean <aserdean at cloudbasesolutions.com> wrote:
> 
> Alin :) (not Sorin).

Of course :)

> Yes both ports are tunneling ports. 
> 
> We cannot save the tunkey because it is different the two ports have different destination addresses.
> 
> OvsOutputBeforeSetAction indeed reinitializes ovsFwdCtx->fwdDetail->SourcePortId and ovsFwdCtx->fwdDetail->SourceNicIndex (https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_blob_master_datapath-2Dwindows_ovsext_Actions.c-23L996&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=iCGmyyaxvxw2vbS3Qa3358oBbSktKftlT4wAi75L7tI&s=0ZEN86sulQ1D-3yq5Afo5hz54Hvl1GklaRz5OF8Rl9Q&e= ),
> but NOT 
> 'ovsFwdCtx->srcVportNo’ (it changes in https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_blob_master_datapath-2Dwindows_ovsext_Actions.c-23L978&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=iCGmyyaxvxw2vbS3Qa3358oBbSktKftlT4wAi75L7tI&s=oGlNU8GFvrrmxCOczS_7e2-HmxrWDHk1rVaDlj0NKQ4&e= , and when reinitialize happens it is with the old value https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_openvswitch_ovs_blob_master_datapath-2Dwindows_ovsext_Actions.c-23L995&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=pNHQcdr7B40b4h6Yb7FIedI1dnBsxdDuTLBYD3JqV80&m=iCGmyyaxvxw2vbS3Qa3358oBbSktKftlT4wAi75L7tI&s=D2Nj5uoC4jtLWrgzh9HJ8hKYNYRx4zQ6Yvuz1YzEayo&e=  ). 

Got it. So, yes, we need to save and restore ‘srcVportNo’, but maybe not the others sine they come from the NBL.

The reason why I said you need to save the ‘tunKey’ is that if output2 is also a tunnel port, where is the context for it? We clear tunKey in OvsClearTunTxCtx().

thanks,
-- Nithin


More information about the dev mailing list