[ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

Ben Pfaff blp at nicira.com
Fri Aug 28 15:58:41 UTC 2015


On Fri, Aug 28, 2015 at 12:25:26AM -0700, Alex Wang wrote:
> On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff <blp at nicira.com> wrote:
> 
> > The text in the log messages use " : " as separators but the common
> > style in OVS log messages is ": ", that is, no space before the colon.
> 
> Could you point me to the place?  only used ':' in the subject.

Pretty much every VLOG_*() in your patch.

> > I would consider adding support for setting the owner and the mode also.
> 
> Could you explain more?  I think since ovs-vswitchd (running as root)
> creates the socket file, we should keep the ownership~

Setting the ownership would be a way to allow a process with a
particular uid to access the socket.

This could wait until later.



More information about the dev mailing list