[ovs-dev] [PATCH 5/5] datapath: check for rx_handler register

Jesse Gross jesse at nicira.com
Fri Aug 28 17:08:23 UTC 2015


On Fri, Aug 28, 2015 at 6:37 AM, Flavio Leitner <fbl at redhat.com> wrote:
> diff --git a/datapath/vport-netdev.c b/datapath/vport-netdev.c
> index de85087..5d1e74f 100644
> --- a/datapath/vport-netdev.c
> +++ b/datapath/vport-netdev.c
> @@ -38,7 +38,8 @@
>  static struct vport_ops ovs_netdev_vport_ops;
>  static void netdev_port_receive(struct vport *vport, struct sk_buff *skb);
>
> -#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,39)
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,39) || \
> +    defined HAVE_NETDEV_RX_HANDLER_REGISTER

I think this will break kernels 2.6.36-38 without the backport. The
register function existed but the prototype of handler changed in
2.6.39.

I also noticed that there is a typo in the version number in the commit message.



More information about the dev mailing list