[ovs-dev] [PATCH] datapath-windows: Surpress flow attribute probe

Ben Pfaff blp at nicira.com
Fri Aug 28 18:07:18 UTC 2015


On Thu, Aug 27, 2015 at 07:57:14PM +0000, Nithin Raju wrote:
> > This patch surpresses flow attribute probing in the windows datapath.
> > 
> > Signed-off-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
> 
> The change look good. Only thing I’d avoid is the OVS_LOG_ERROR()
> statement. The documentation for ‘OVS_FLOW_ATTR_PROBE’ explicitly
> mentions that logging should be suppressed.

When it's supported, it's supposed to suppress logging of *other*
errors.  Since it *isn't* supported, I think it's fair game to log that.

> Acked-by: Nithin Raju <nithin at vmware.com>

Thanks Alin and Nithin, I'll apply this to master and branch-2.4 in a
minute.



More information about the dev mailing list