[ovs-dev] [PATCH 2/3] service controller: Allow change to punix socket file group ownership.

ALeX Wang ee07b291 at gmail.com
Sun Aug 30 06:01:59 UTC 2015


On 28 August 2015 at 00:25, Alex Wang <alexw at nicira.com> wrote:

> On Wed, Aug 26, 2015 at 2:13 PM, Ben Pfaff <blp at nicira.com> wrote:
>
> > On Fri, Aug 21, 2015 at 11:10:32PM -0700, Alex Wang wrote:
> > > This commit adds a new key-value pair, 'punix_file_group=<user group>',
> > > to the 'other_config' column in the 'Controller' table.  This new
> config
> > > allows user to change the punix socket file's group ownership, so that
> > > non-root process can also connect to ovs bridge.
> > >
> > > Signed-off-by: Alex Wang <alexw at nicira.com>
> >
> > POSIX says sysconf(_SC_GETGR_R_SIZE_MAX) can return -1.  It's probably
> > best to pick some reasonable default in that case.
> >
> > I don't think POSIX requires getgrnam_r() to set errno; it's pretty
> > unclear on that account.  It definitely requires the return value to be
> > a nonzero errno value to indicate an error, so I'd recommend using the
> > return value instead of errno.
> >
>

Sorry for the careless reading of manpage, will fix these,

Thanks,
Alex Wang,



More information about the dev mailing list