[ovs-dev] [PATCH] flow: Fix MSVC compile errors.

Nithin Raju nithin at vmware.com
Mon Aug 31 17:56:34 UTC 2015


> On Aug 30, 2015, at 7:40 AM, Ben Pfaff <blp at nicira.com> wrote:
> 
> MSVC doesn't like the change in 'const' between function declaration and
> definition: it reports "formal parameter 2 different from declaration" for
> each of the functions in flow.h corrected by this (commit.  I think it's
> technically wrong about that, standards-wise.)
> 
> MSVC doesn't like an empty-brace initializer.  (I think it's technically
> right about that, standards-wise.)
> 
> This commit attempts to fix both problems, but I have not tested it with
> MSVC.
> 
> CC: Jarno Rajahalme <jrajahalme at nicira.com>
> Signed-off-by: Ben Pfaff <blp at nicira.com>

Thanks Ben for the patch.

There seems to be one a change required in netdev-windows.c. I’ll send out a patch for that.

Acked-by: Nithin Raju <nithin at vmware.com>
Tested-by: Nithin Raju <nithin at vmware.com>

thanks,
-- Nithin


More information about the dev mailing list