[ovs-dev] [PATCH] datapath-windows: Don't assert for unknown actions

[Sairam Venugopal]

Thanks for the patch.

Acked-by: Sairam Venugopal <vsairam at vmware.com>



On 11/25/15, 12:32 PM, "Nithin Raju" <nithin at vmware.com> wrote:

>On Hyper-V, we currently don't validate a flow to see if datapath can
>indeed execute all the actions specified or not. While support for it
>gets implemented, an ASSERT seems too strong. I'm working on the support
>for actions validation. Here's a workaround in the meantime to help
>debugging.
>
>Signed-off-by: Nithin Raju <nithin at vmware.com>
>---
> datapath-windows/ovsext/Actions.c | 18 +++---------------
> 1 file changed, 3 insertions(+), 15 deletions(-)
>
>diff --git a/datapath-windows/ovsext/Actions.c
>b/datapath-windows/ovsext/Actions.c
>index e902983..7d34458 100644
>--- a/datapath-windows/ovsext/Actions.c
>+++ b/datapath-windows/ovsext/Actions.c
>@@ -1360,22 +1360,10 @@ OvsExecuteSetAction(OvsForwardingContext
>*ovsFwdCtx,
>         RtlCopyMemory(&ovsFwdCtx->tunKey, &tunKey, sizeof
>ovsFwdCtx->tunKey);
>         break;
>     }
>-    case OVS_KEY_ATTR_SKB_MARK:
>-    /* XXX: Not relevant to Hyper-V. Return OK */
>-    break;
>-    case OVS_KEY_ATTR_UNSPEC:
>-    case OVS_KEY_ATTR_ENCAP:
>-    case OVS_KEY_ATTR_ETHERTYPE:
>-    case OVS_KEY_ATTR_IN_PORT:
>-    case OVS_KEY_ATTR_VLAN:
>-    case OVS_KEY_ATTR_ICMP:
>-    case OVS_KEY_ATTR_ICMPV6:
>-    case OVS_KEY_ATTR_ARP:
>-    case OVS_KEY_ATTR_ND:
>-    case __OVS_KEY_ATTR_MAX:
>+
>     default:
>-    OVS_LOG_INFO("Unhandled attribute %#x", type);
>-    ASSERT(FALSE);
>+        OVS_LOG_INFO("Unhandled attribute %#x", type);
>+        break
>     }
>     return status;
> }
>-- 
>1.8.5.6
>
>_______________________________________________
>dev mailing list
>dev at openvswitch.org
>https://urldefense.proofpoint.com/v2/url?u=http-3A__openvswitch.org_mailma
>n_listinfo_dev&d=BQIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Dc
>ruz40PROJ40ROzSpxyQSLw6fcrOWpJgEcEmNR3JEQ&m=bJw80vN4kTApMoeiII-yuUy3B3UfaQ
>kofjX2CR1CwS4&s=bGDKEvKIo16mIe4PTdxwl9ZfQ4L5diag9yZhWMVNRlQ&e=