[ovs-dev] [monitor2 v2 7/9] ovsdb-client: support monitor2

Liran Schour LIRANS at il.ibm.com
Tue Dec 1 14:20:38 UTC 2015


"dev" <dev-bounces at openvswitch.org> wrote on 25/11/2015 12:16:01 AM:

> From: Andy Zhou <azhou at nicira.com>
> @@ -617,6 +621,101 @@ monitor_print(struct json *table_updates,
> }
> 
> static void
> +monitor2_print_row(struct json *row, const char *type, const char 
*uuid,
> +                   const struct ovsdb_column_set *columns, struct table 
*t)
> +{
> +    if (!strcmp(type, "delete")) {
> +        if (row->type != JSON_NULL) {
> +            ovs_error(0, "delete method does not expect <row>");
> +            return;
> +        }
> +
> +        table_add_row(t);
> +        table_add_cell(t)->text = xstrdup(uuid);
> +        table_add_cell(t)->text = xstrdup(type);
> +    } else {
> +        if (!row || row->type != JSON_OBJECT) {
> +            ovs_error(0, "<row> is not object");
> +            return;
> +        }
> +        monitor_print_row(row, type, uuid, columns, t);
> +    }
> +}

Update2 does not send default values, therefore we will miss these values 
on ovsdb-client.
I can fix it on monitor_cond or you can send an updated patch.




More information about the dev mailing list