[ovs-dev] [PATCH 3/3] ovn.at: Fix races
Flavio Fernandes
ffernand at redhat.com
Thu Dec 3 04:30:15 UTC 2015
On Wed, Dec 2, 2015 at 11:03 PM, Takashi Yamamoto <yamamoto at midokura.com>
wrote:
> hi,
>
> On Thu, Dec 3, 2015 at 3:26 AM, Flavio Fernandes <ffernand at redhat.com>
> wrote:
> > On Thu, Nov 26, 2015 at 4:41 AM, YAMAMOTO Takashi <yamamoto at midokura.com
> >
> > wrote:
> >
> >> These tests are racy as nothing prevents packet re-ordering.
> >> Fix them by sorting outputs before comparing.
> >>
> >> Signed-off-by: YAMAMOTO Takashi <yamamoto at midokura.com>
> >>
> >
> > Reviewed-by: Flavio Fernandes <ffernand at redhat.com>
>
> i've already merged this patch.
> anyway, thank you for review!
>
>
np, Takashi!
I have a slow machine and i found another issue in the test. it has to do
with the "sleep 1"
that right before [vtep-ctl]. I would like to replace that sleep 1 with a
max retry loop, so it is
faster [or slower], depending on the dut.
i will submit a patch [in a few days] and ask for your review. :)
Best,
-- flavio
[1]: ... vtep-ctl bind-ls br-vtep br-vtep_n2 0 lsw0
https://gist.github.com/anonymous/95302f21dedcae9c26fc#file-gistify935119-txt-L10
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > http://openvswitch.org/mailman/listinfo/dev
>
More information about the dev
mailing list