[ovs-dev] [PATCH] ovn-controller: Add clarifying comment about main loop in binding_run().

Justin Pettit jpettit at ovn.org
Fri Dec 11 17:48:32 UTC 2015


> On Dec 11, 2015, at 8:02 AM, Russell Bryant <russell at ovn.org> wrote:
> 
> On 12/10/2015 08:57 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit <jpettit at ovn.org>
>> ---
>> ovn/controller/binding.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/ovn/controller/binding.c b/ovn/controller/binding.c
>> index 7f31b31..8461df6 100644
>> --- a/ovn/controller/binding.c
>> +++ b/ovn/controller/binding.c
>> @@ -151,6 +151,9 @@ binding_run(struct controller_ctx *ctx, const struct ovsrec_bridge *br_int,
>>         ctx->ovnsb_idl_txn,"ovn-controller: updating port bindings for '%s'",
>>         chassis_id);
>> 
>> +    /* Run through each binding record to see if it is resident on this
>> +     * chassis and update the binding accordingly.  This includes both
>> +     * directly connected logical ports and children of those ports. */
>>     SBREC_PORT_BINDING_FOR_EACH(binding_rec, ctx->ovnsb_idl) {
>>         if (sset_find_and_delete(&lports, binding_rec->logical_port) ||
>>                 (binding_rec->parent_port && binding_rec->parent_port[0] &&
>> 
> 
> Acked-by: Russell Bryant <russell at ovn.org>

Thanks.  I went ahead and pushed this to master and 2.5.

--Justin





More information about the dev mailing list