[ovs-dev] [PATCH] lib: fix sparse warnings

Joe Stringer joe at ovn.org
Tue Dec 15 18:55:47 UTC 2015


On 14 December 2015 at 15:08, Andy Zhou <azhou at ovn.org> wrote:
> Fixes the following sparse warning messages:
>
>     lib/ovsdb-idl.c:146:12: error: symbol 'table_updates_names' was not
>     declared. Should it be static?
>     lib/ovsdb-idl.c:147:12: error: symbol 'table_update_names' was not
>     declared. Should it be static?
>     lib/ovsdb-idl.c:148:12: error: symbol 'row_update_names' was not
>     declared. Should it be static?
>
> Reported-by: Joe Perches <joe at perches.com>
> See: https://travis-ci.org/openvswitch/ovs/jobs/96737772#L870
> Signed-off-by: Andy Zhou <azhou at ovn.org>

Did Joe Perches also report the error? Nice to know I'm not the only
one checking Travis :-)

Just a note with the travis builds, you've already pointed out the
failure in the commit message, so linking the failure doesn't provide
much additional information. IMO It would provide more information if
it is a build with this patch, so you can show that it fixes the
build.

Acked-by: Joe Stringer <joe at ovn.org>



More information about the dev mailing list