[ovs-dev] [PATCH 1/5] ovn-ctl: Add daemon status functions.

Russell Bryant russell at ovn.org
Wed Dec 16 14:05:13 UTC 2015


On 12/16/2015 02:00 AM, Ben Pfaff wrote:
> On Tue, Dec 15, 2015 at 10:59:58PM -0800, Ben Pfaff wrote:
>> On Tue, Dec 15, 2015 at 09:52:02AM -0800, Gurucharan Shetty wrote:
>>> Signed-off-by: Gurucharan Shetty <guru at ovn.org>
>>> ---
>>>  ovn/utilities/ovn-ctl |    6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl
>>> index 3e2ccf9..b171934 100755
>>> --- a/ovn/utilities/ovn-ctl
>>> +++ b/ovn/utilities/ovn-ctl
>>> @@ -225,6 +225,12 @@ case $command in
>>>      restart_controller)
>>>          restart_controller
>>>          ;;
>>> +    status_northd)
>>> +        daemon_status ovn-northd || exit 1
>>> +        ;;
>>> +    status_controller)
>>> +        daemon_status ovn-controller || exit 1
>>> +        ;;
>>
>> Do you think it's worth breaking out individual statuses this way?
>> "ovs-ctl status" shows all OVS daemons' status; maybe "ovn-ctl status"
>> should follow the same pattern.
> 
> Oh, but in case you disagree, I don't feel strongly, so have an ack if
> you want:
> Acked-by: Ben Pfaff <blp at ovn.org>

It seems reasonable that you might want to check the status of only
ovn-controller on a hypervisor, for example.  We could have a third
"status" arg that checks all though.

Acked-by: Russell Bryant <russell at ovn.org>

-- 
Russell Bryant



More information about the dev mailing list