[ovs-dev] [PATCH] tun-metadata: Fix memory leak in tun_metadata_add_entry() corner case.

Ben Pfaff blp at ovn.org
Sat Dec 19 05:57:26 UTC 2015


On Thu, Dec 17, 2015 at 01:55:31AM -0800, Ben Pfaff wrote:
> Found by valgrind.
> 
> CC: Jesse Gross <jgross at vmware.com>
> Reported-by: William Tu <u9012063 at gmail.com>
> Signed-off-by: Ben Pfaff <blp at ovn.org>

I should have noted that I wrote this while reviewing the first patch
that William submitted:
        https://patchwork.ozlabs.org/patch/555444/

Most of that patch looks good to me, but I think that the fix in it
corresponding to this one is wrong (I believe that it can free a pointer
not returned by malloc()), hence this patch here.

William, I will continue reviewing your patch series.



More information about the dev mailing list